[webkit-reviews] review requested: [Bug 206623] Add an option for logging total phase times : [Attachment 388490] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 22 17:15:17 PST 2020


Keith Miller <keith_miller at apple.com> has asked  for review:
Bug 206623: Add an option for logging total phase times
https://bugs.webkit.org/show_bug.cgi?id=206623

Attachment 388490: patch

https://bugs.webkit.org/attachment.cgi?id=388490&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 388490
  --> https://bugs.webkit.org/attachment.cgi?id=388490
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388490&action=review

r=me too with comment.

> Source/JavaScriptCore/runtime/OptionsList.h:167
> +    v(Bool, reportTotalPhaseTimes, false, Normal, nullptr) \

Plox add a string here that explains the difference between this only prints at
the end.


More information about the webkit-reviews mailing list