[webkit-reviews] review granted: [Bug 206608] REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated : [Attachment 388459] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 206608: REGRESSION (r253519): [WKWebView
evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even
when JavaScript cannot be evaluated
https://bugs.webkit.org/show_bug.cgi?id=206608

Attachment 388459: Patch

https://bugs.webkit.org/attachment.cgi?id=388459&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 388459
  --> https://bugs.webkit.org/attachment.cgi?id=388459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388459&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:235
> +    TCPServer server([](int socket) {

You could've used HTTPServer since this only adds headers fields and body, but
this is fine too.