[webkit-reviews] review granted: [Bug 206389] It should be possible to build JavaScriptCore with LLVM Source-based Code Coverage, run the tests and see the coverage data : [Attachment 388447] proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tuomas Karkkainen
<tuomas.webkit at apple.com>'s request for review:
Bug 206389: It should be possible to build JavaScriptCore with LLVM
Source-based Code Coverage, run the tests and see the coverage data
https://bugs.webkit.org/show_bug.cgi?id=206389

Attachment 388447: proposed patch

https://bugs.webkit.org/attachment.cgi?id=388447&action=review




--- Comment #18 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 388447
  --> https://bugs.webkit.org/attachment.cgi?id=388447
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388447&action=review

I guess we should simplify things to stop using ASAN_ variables then!

> Tools/Scripts/webkitdirs.pm:908
> +    # treats errors as non-fatal when it encounters missing symbols related
to coverage

Please add a period at the end of the sentence.