[webkit-reviews] review granted: [Bug 205485] [WinCairo] Some of combining family glyphs are replaced by space glyphs : [Attachment 387990] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 205485: [WinCairo] Some of combining family glyphs are replaced by space
glyphs
https://bugs.webkit.org/show_bug.cgi?id=205485

Attachment 387990: Patch

https://bugs.webkit.org/attachment.cgi?id=387990&action=review




--- Comment #9 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 387990
  --> https://bugs.webkit.org/attachment.cgi?id=387990
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387990&action=review

> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:146
> +	   int endGlyphIndex = !finish ? clusters[endStringIndex] : -1;

Nowadays we prefer to use out-of-band sentinels. How about Optional<unsigned>?