[webkit-reviews] review granted: [Bug 206561] Add missing NS_NOESCAPE to CFNetwork SPI : [Attachment 388369] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 206561: Add missing NS_NOESCAPE to CFNetwork SPI
https://bugs.webkit.org/show_bug.cgi?id=206561

Attachment 388369: Patch

https://bugs.webkit.org/attachment.cgi?id=388369&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 388369
  --> https://bugs.webkit.org/attachment.cgi?id=388369
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388369&action=review

r=me

> Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:-49
> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) ||
(PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000)
> - at interface NSHTTPCookieStorage (Staging)
> -- (void)_getCookiesForURL:(NSURL *)url mainDocumentURL:(NSURL
*)mainDocumentURL partition:(NSString *)partition
policyProperties:(NSDictionary*)props completionHandler:(void (^)(NSArray
*))completionHandler;
> -- (void)_setCookies:(NSArray *)cookies forURL:(NSURL *)URL
mainDocumentURL:(NSURL *)mainDocumentURL policyProperties:(NSDictionary*)
props;
> - at end
> -#endif

Nice!