[webkit-reviews] review granted: [Bug 191306] Automatic link replacement via "Smart links" should emit "insertLink" input events : [Attachment 388368] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 191306: Automatic link replacement via "Smart links" should emit
"insertLink" input events
https://bugs.webkit.org/show_bug.cgi?id=191306

Attachment 388368: Patch

https://bugs.webkit.org/attachment.cgi?id=388368&action=review




--- Comment #11 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 388368
  --> https://bugs.webkit.org/attachment.cgi?id=388368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388368&action=review

> Source/WebCore/ChangeLog:12
> +	   Test: fast/events/emit-insertLink.html

Let's update this to fast/events/input-event-insert-link.html as well.

> LayoutTests/ChangeLog:11
> +	   * fast/events/emit-insertLink-expected.txt: Added.
> +	   * fast/events/emit-insertLink.html: Added.

Let's update these to fast/events/input-event-insert-link.html as well.

> LayoutTests/fast/events/input-event-insert-link.html:14
> +

I think it helps to have a quick description here; perhaps something like,
`description("This test verifies that input events of inputType 'insertLink'
are dispatched when automatically replacing text with a link.");`.