[webkit-reviews] review granted: [Bug 205821] Test history links on the dashboard should go to the new results database : [Attachment 388341] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 21 14:48:29 PST 2020
Jonathan Bedard <jbedard at apple.com> has granted Matt Lewis
<jlewis3 at apple.com>'s request for review:
Bug 205821: Test history links on the dashboard should go to the new results
database
https://bugs.webkit.org/show_bug.cgi?id=205821
Attachment 388341: Patch
https://bugs.webkit.org/attachment.cgi?id=388341&action=review
--- Comment #6 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 388341
--> https://bugs.webkit.org/attachment.cgi?id=388341
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=388341&action=review
>>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui.js:50
>> + return 'https://results.webkit.org/?suite=layout-tests&test=' +
encodeURIComponent(testsParameter);
>
> Do we need the '/' in 'results.webkit.org/'?
It it pedantically correct, but we don't need it.
More information about the webkit-reviews
mailing list