[webkit-reviews] review granted: [Bug 206540] [macOS] Add managed preference to allow synchronous XHR during page dismissal : [Attachment 388311] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 206540: [macOS] Add managed preference to allow synchronous XHR during page
dismissal
https://bugs.webkit.org/show_bug.cgi?id=206540

Attachment 388311: Patch

https://bugs.webkit.org/attachment.cgi?id=388311&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 388311
  --> https://bugs.webkit.org/attachment.cgi?id=388311
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388311&action=review

r=me

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:67
> +bool defaultDisallowSyncXHRDuringPageDismissalEnabled()

To avoid double negatives, could we rename this to defaultAllow...
Same with the preference name.

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:75
> +    return true;

We should put a FIXME with a radar for iOS.