[webkit-reviews] review granted: [Bug 206449] [OpenSSL] Add stubs and build for Web Crypto : [Attachment 388107] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 206449: [OpenSSL] Add stubs and build for Web Crypto
https://bugs.webkit.org/show_bug.cgi?id=206449

Attachment 388107: Patch

https://bugs.webkit.org/attachment.cgi?id=388107&action=review




--- Comment #4 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 388107
  --> https://bugs.webkit.org/attachment.cgi?id=388107
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388107&action=review

LGTM. r=me. Please address the following minor issues.

> Source/WebCore/crypto/keys/CryptoKeyRSA.h:55
> +typedef std::unique_ptr<void*> PlatformRSAKeyContainer;

PlatformRSAKey, I believe.

> Source/WebCore/crypto/openssl/CryptoAlgorithmAES_CBCOpenSSL.cpp:29
> +#if ENABLE(WEB_CRYPTO)

I wonder after your change if this ENABLE macro is still needed.

> Source/WebCore/crypto/openssl/CryptoAlgorithmRSA_PSSOpenSSL.cpp:29
> +#if ENABLE(WEB_CRYPTO) && HAVE(RSA_PSS)

You probably don't need to include the HAVE(RSA_PSS) macro. And you probably
need to set it to 1 for your ports.