[webkit-reviews] review granted: [Bug 206459] Add SPI to show and hide placeholder : [Attachment 388321] Patch and layout test

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 206459: Add SPI to show and hide placeholder
https://bugs.webkit.org/show_bug.cgi?id=206459

Attachment 388321: Patch and layout test

https://bugs.webkit.org/attachment.cgi?id=388321&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 388321
  --> https://bugs.webkit.org/attachment.cgi?id=388321
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=388321&action=review

> Source/WebKit/ChangeLog:10
> +	   Add Modern WebKit SPI to allow a client to control whether the
placeholder can be shown or
> +	   not when a form control is empty. This is for aesthetics.

It doesn't look like this patch actually adds "Modern WebKit SPI to allow a
client to control whether the placeholder can be shown…". Was this intended for
a followup?

> Source/WebCore/html/HTMLTextFormControlElement.cpp:178
> +    m_canShowPlaceholder = canShowPlaceholder;

Nit - is it necessary to updatePlaceholderVisibility(); in the case where
m_canShowPlaceholder didn't change?