[webkit-reviews] review granted: [Bug 206507] [LFC][IFC] InlineFormattingContext::lineLayout should take a InlineItem range : [Attachment 388249] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 20 12:20:39 PST 2020


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 206507: [LFC][IFC] InlineFormattingContext::lineLayout should take a
InlineItem range
https://bugs.webkit.org/show_bug.cgi?id=206507

Attachment 388249: Patch

https://bugs.webkit.org/attachment.cgi?id=388249&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 388249
  --> https://bugs.webkit.org/attachment.cgi?id=388249
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388249&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.h:54
> +	   bool isEmpty() const { return start >= end; }

Why would start > end?


More information about the webkit-reviews mailing list