[webkit-reviews] review granted: [Bug 206373] [Cocoa] Broker access to the PowerManagement API : [Attachment 388120] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 206373: [Cocoa] Broker access to the PowerManagement API
https://bugs.webkit.org/show_bug.cgi?id=206373

Attachment 388120: Patch

https://bugs.webkit.org/attachment.cgi?id=388120&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 388120
  --> https://bugs.webkit.org/attachment.cgi?id=388120
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388120&action=review

> Source/WebCore/platform/cocoa/PowerUtils.h:2
> +* Copyright (C) 2020 Apple Inc. All rights reserved.

File naming: A file named "XXXUtils" is against WebKit coding style. Not sure
if we wrote it down or not.

I suggest the name SystemBattery.h/mm. But there are probably other good names
to consider.

The vague programmer word "utilities" should be avoided, even though this rule
has not been followed consistently. Lets not make another header with a name
like this. Even just "Power.h" might be OK.

The abbreviation "utils" goes against our stance against unnecessary
abbreviation.