[webkit-reviews] review granted: [Bug 204944] To skip bytecode-cache tests do not call skip : [Attachment 388232] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 20 08:12:57 PST 2020


Saam Barati <sbarati at apple.com> has granted Paulo Matos <pmatos at igalia.com>'s
request for review:
Bug 204944: To skip bytecode-cache tests do not call skip
https://bugs.webkit.org/show_bug.cgi?id=204944

Attachment 388232: Patch

https://bugs.webkit.org/attachment.cgi?id=388232&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 388232
  --> https://bugs.webkit.org/attachment.cgi?id=388232
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388232&action=review

> Tools/ChangeLog:8
> +	   Explicitly calling skip on non-darwin OS, would generate a bogus
skip line

“on” => “on a”
“OS,” => “OS”


More information about the webkit-reviews mailing list