[webkit-reviews] review granted: [Bug 206495] [WPE] Add WebKitRectangle, use it for WebKitWebView's SHOW_MENU signal : [Attachment 388227] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 206495: [WPE] Add WebKitRectangle, use it for WebKitWebView's SHOW_MENU
signal
https://bugs.webkit.org/show_bug.cgi?id=206495

Attachment 388227: Patch

https://bugs.webkit.org/attachment.cgi?id=388227&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 388227
  --> https://bugs.webkit.org/attachment.cgi?id=388227
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388227&action=review

> Source/WebKit/UIProcess/API/wpe/WebKitRectangle.cpp:52
> +    copy->x = rectangle->x;
> +    copy->y = rectangle->y;
> +    copy->width = rectangle->width;
> +    copy->height = rectangle->height;

I think you can do *copy = *rectangle

> Source/WebKit/UIProcess/API/wpe/WebKitRectangle.cpp:71
> +G_DEFINE_BOXED_TYPE(WebKitRectangle, webkit_rectangle,
webkit_rectangle_copy, webkit_rectangle_free);

Remove the trailing ;

> Source/WebKit/UIProcess/API/wpe/WebKitRectangle.h:41
> + * Since: 2.24

2.28

> Source/WebKit/UIProcess/API/wpe/WebKitRectangle.h:56
> +

webkit_rectangle_copy and free declaractions are missing here. If we want to
leave them as private in favor of g_boxed_copy/free, they should be static in
the cpp and undocumented.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:61
> -    static gboolean showOptionMenuCallback(WebKitWebView* webView,
WebKitOptionMenu* menu, gpointer*, OptionMenuTest* test)
> +    static gboolean showOptionMenuCallback(WebKitWebView* webView,
WebKitOptionMenu* menu, WebKitRectangle* rect, OptionMenuTest* test)

Can we define PlatformRectangle at the top and then use it instead of
WebKit/Gdk to remove some #ifdefs?