[webkit-reviews] review granted: [Bug 206468] [Media in GPU process] Pipe more MediaPlayerPrivate and client methods : [Attachment 388136] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 206468: [Media in GPU process] Pipe more MediaPlayerPrivate and client
methods
https://bugs.webkit.org/show_bug.cgi?id=206468

Attachment 388136: Patch

https://bugs.webkit.org/attachment.cgi?id=388136&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 388136
  --> https://bugs.webkit.org/attachment.cgi?id=388136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388136&action=review

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:476
> +   
m_webProcessConnection->send(Messages::RemoteMediaPlayerManager::CurrentPlaybac
kTargetIsWirelessChanged(m_id), 0);

HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged immediately
calls m_player->isCurrentPlaybackTargetWireless(), so we should push that state
here and cache it in the MediaPlayerPrivateRemote.

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:684
> +    if (m_player)

m_player is never NULL.

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:942
> +    if (m_player)

Ditto.

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:948
> +    if (m_player)

Ditto.

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:954
> +    if (m_player)

Ditto.