[webkit-reviews] review granted: [Bug 206413] ASSERT in case a service worker cannot be terminated in a timely manner : [Attachment 388038] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 206413: ASSERT in case a service worker cannot be terminated in a timely
manner
https://bugs.webkit.org/show_bug.cgi?id=206413

Attachment 388038: Patch

https://bugs.webkit.org/attachment.cgi?id=388038&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 388038
  --> https://bugs.webkit.org/attachment.cgi?id=388038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388038&action=review

> Source/WebCore/workers/service/context/SWContextManager.cpp:168
> +    ASSERT_NOT_REACHED();
>      _exit(EXIT_FAILURE);

Builds passed on EWS, but I recall some ports failing to build because of
unreachable code warnings in the past. Maybe they disabled the warning.