[webkit-reviews] review granted: [Bug 203355] EXIF orientation is ignored for some CSS images : [Attachment 388097] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 17 16:31:01 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 203355: EXIF orientation is ignored for some CSS images
https://bugs.webkit.org/show_bug.cgi?id=203355

Attachment 388097: Patch

https://bugs.webkit.org/attachment.cgi?id=388097&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 388097
  --> https://bugs.webkit.org/attachment.cgi?id=388097
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388097&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:162
> +    FloatRect rect = { IntPoint::zero(), size() };

It's a bit weird to initialize the location of a FloatRect with IntPoint::zero

Is size() computed respecting orientation? I.e. do we know this code won't
distort the image?


More information about the webkit-reviews mailing list