[webkit-reviews] review granted: [Bug 206441] Some iOS tests using UIHelper.dragFromPointToPoint() are flakey : [Attachment 388085] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 206441: Some iOS tests using UIHelper.dragFromPointToPoint() are flakey
https://bugs.webkit.org/show_bug.cgi?id=206441

Attachment 388085: Patch

https://bugs.webkit.org/attachment.cgi?id=388085&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 388085
  --> https://bugs.webkit.org/attachment.cgi?id=388085
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388085&action=review

r=mews

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:434
> +static NSDictionary *dictionaryForFingerEventWithContentPoint(CGPoint point,
NSString* phase, Seconds timeOffset)

Nit - * on other side.

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:459
> +    NSDictionary* touchDownInfo =
dictionaryForFingerEventWithContentPoint(startPoint, HIDEventPhaseBegan, 0_s);

Nit - * on other side.

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:467
> +    NSDictionary* liftUpInfo =
dictionaryForFingerEventWithContentPoint(endPoint, HIDEventPhaseEnded,
Seconds(durationSeconds));

Ditto.