[webkit-reviews] review denied: [Bug 206012] REGRESSION: ( r254222 ) [ Mac Debug ] TestWebKitAPI.AsyncFunction.Promise is timing out : [Attachment 388059] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has denied Brady Eidson
<beidson at apple.com>'s request for review:
Bug 206012: REGRESSION: ( r254222 ) [ Mac Debug ]
TestWebKitAPI.AsyncFunction.Promise is timing out
https://bugs.webkit.org/show_bug.cgi?id=206012

Attachment 388059: Patch

https://bugs.webkit.org/attachment.cgi?id=388059&action=review




--- Comment #6 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 388059
  --> https://bugs.webkit.org/attachment.cgi?id=388059
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388059&action=review

r- because I think this is backwards. But maybe I'm misunderstanding the logic.

> Tools/ChangeLog:9
> +	   But it turns out ne copy of the function call and an API call to
force a GC pass seems to be enough.

Nit: Typo, I'm not sure what the exact sentence you were trying to say was
though... :P

> Tools/TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:275
> +	   [webView _callAsyncJavaScriptFunction:functionBody withArguments:nil
inWorld:_WKContentWorld.pageContentWorld completionHandler:[&] (id result,
NSError *error) {
> +	       EXPECT_NULL(result);
> +	       EXPECT_TRUE(error != nil);
> +	       EXPECT_TRUE([[error description] containsString:@"no longer
reachable"]);
> +	       done = true;

I think this is the opposite of what you want? I think you want to confirm that
it returned an error at least once not 100% of the time.