[webkit-reviews] review granted: [Bug 206385] [iOS] Focusing editable element with WebPage::selectPositionAtPoint() does not bring up keyboard : [Attachment 388057] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 17 10:45:12 PST 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 206385: [iOS] Focusing editable element with
WebPage::selectPositionAtPoint() does not bring up keyboard
https://bugs.webkit.org/show_bug.cgi?id=206385

Attachment 388057: Patch

https://bugs.webkit.org/attachment.cgi?id=388057&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 388057
  --> https://bugs.webkit.org/attachment.cgi?id=388057
Patch

This would preferably have a test.

I think you could write an API test for this that verifies
-[_WKFocusedElementInfo userInitiated] is YES when using selectPositionAtPoint
in a text field.


More information about the webkit-reviews mailing list