[webkit-reviews] review granted: [Bug 206408] Video sound sometimes keeps playing in page cache : [Attachment 388026] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 17 09:06:39 PST 2020


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 206408: Video sound sometimes keeps playing in page cache
https://bugs.webkit.org/show_bug.cgi?id=206408

Attachment 388026: Patch

https://bugs.webkit.org/attachment.cgi?id=388026&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 388026
  --> https://bugs.webkit.org/attachment.cgi?id=388026
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388026&action=review

> LayoutTests/http/tests/navigation/resources/page-cache-video-helper.html:7
> +	     localStorage.setItem("pageMediaState",
internals.pageMediaState());

This state is never read back from the page cache, should it be?


More information about the webkit-reviews mailing list