[webkit-reviews] review granted: [Bug 206402] Setting kVTCompressionPropertyKey_DataRateLimits on RTCVideoEncoderH264 fails : [Attachment 388017] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 206402: Setting kVTCompressionPropertyKey_DataRateLimits on
RTCVideoEncoderH264 fails
https://bugs.webkit.org/show_bug.cgi?id=206402

Attachment 388017: Patch

https://bugs.webkit.org/attachment.cgi?id=388017&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 388017
  --> https://bugs.webkit.org/attachment.cgi?id=388017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388017&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/helpe
rs.cc:134
> +    RTC_LOG(LS_ERROR) << "VTSessionSetProperty failed to set: " <<
key_string

it might be worth also logging 'vtSession' so we know which call was made