[webkit-reviews] review granted: [Bug 206368] [JSC] add DFG/FTL support for op_to_property_key : [Attachment 387942] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 206368: [JSC] add DFG/FTL support for op_to_property_key
https://bugs.webkit.org/show_bug.cgi?id=206368

Attachment 387942: Patch

https://bugs.webkit.org/attachment.cgi?id=387942&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 387942
  --> https://bugs.webkit.org/attachment.cgi?id=387942
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387942&action=review

LGTM too. I found one minor perf bug

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2530
> +	       m_state.setShouldTryConstantFolding(true);

You need to write the code inside DFGConstantFoldingPhase that corresponds to
this and actually does the identity conversion.