[webkit-reviews] review denied: [Bug 206373] [Cocoa] Broker access to the PowerManagement API : [Attachment 387964] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 16 21:07:14 PST 2020
Sam Weinig <sam at webkit.org> has denied Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 206373: [Cocoa] Broker access to the PowerManagement API
https://bugs.webkit.org/show_bug.cgi?id=206373
Attachment 387964: Patch
https://bugs.webkit.org/attachment.cgi?id=387964&action=review
--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 387964
--> https://bugs.webkit.org/attachment.cgi?id=387964
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=387964&action=review
> Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.h:40
> +WEBCORE_EXPORT void setSystemHasBattery(bool);
> +WEBCORE_EXPORT bool systemHasBattery();
This does not seem like the right file for these. If they need to be exposed
outside of the .mm file, please move them to a more appropriate place or create
a new file for them.
More information about the webkit-reviews
mailing list