[webkit-reviews] review granted: [Bug 180139] [ESNext] Enables a way to throw an error on ByteCodeGenerator step : [Attachment 387982] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 180139: [ESNext] Enables a way to throw an error on ByteCodeGenerator step
https://bugs.webkit.org/show_bug.cgi?id=180139

Attachment 387982: Patch

https://bugs.webkit.org/attachment.cgi?id=387982&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 387982
  --> https://bugs.webkit.org/attachment.cgi?id=387982
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387982&action=review

r=me

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:125
> +	   return generator.emitThrowExpressionTooDeepException();

It's hokey that we use "ExpressionTooDeepException" to mean OutOfMemoryError. 
Maybe we should change this later (in another patch) especially now that we're
using in a case that has nothing to do with recursing into nested expressions.