[webkit-reviews] review granted: [Bug 206340] Rename SelectionData classes and structures HighlightData, etc to be more inclusive for their new use cases : [Attachment 387923] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 206340: Rename SelectionData classes and structures HighlightData, etc to
be more inclusive for their new use cases
https://bugs.webkit.org/show_bug.cgi?id=206340

Attachment 387923: Patch

https://bugs.webkit.org/attachment.cgi?id=387923&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 387923
  --> https://bugs.webkit.org/attachment.cgi?id=387923
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387923&action=review

r=me provided the following issues are addressed.

> Source/WebCore/rendering/HighlightData.cpp:48
> +struct SelectionData {

I guess you're gonna rename this in a followup?

> Source/WebCore/rendering/RenderObject.h:696
> +    enum HighlightState {

Please use enum class instead.
We then don't have to prefix every value with "Highlight".
Also specify the width: uint8_t.

> WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:60
> -		  BuildableName = "libANGLE-shared.dylib"
> +		  BuildableName = "libANGLE.a"

revert?