[webkit-reviews] review granted: [Bug 206382] Ensure full URLs for relative path images for social meta data : [Attachment 387976] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 206382: Ensure full URLs for relative path images for social meta data
https://bugs.webkit.org/show_bug.cgi?id=206382

Attachment 387976: Patch

https://bugs.webkit.org/attachment.cgi?id=387976&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 387976
  --> https://bugs.webkit.org/attachment.cgi?id=387976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387976&action=review

r=me, with a few comments

> Websites/webkit.org/wp-content/plugins/social-meta.php:84
> +	   if ($image_url[0] === '/')

Should we move this logic to the end of the initial `<?php` block at the top of
this file?  That way, if HTML tags are added for other social platforms above
this, they won't "miss" this logic.

> Websites/webkit.org/wp-content/plugins/social-meta.php:85
> +	       $image_url = get_home_url(null,$image_url);

Style: should have space between `null, $image_url`.