[webkit-reviews] review granted: [Bug 205965] [PlayStation] Enable WebKit : [Attachment 387954] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 205965: [PlayStation] Enable WebKit
https://bugs.webkit.org/show_bug.cgi?id=205965

Attachment 387954: Patch

https://bugs.webkit.org/attachment.cgi?id=387954&action=review




--- Comment #5 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 387954
  --> https://bugs.webkit.org/attachment.cgi?id=387954
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387954&action=review

r=me with nits

> Source/WebKit/Platform/unix/ModuleUnix.cpp:40
> +void* Module::platformFunctionPointer(const char* functionName) const

Seems like we should recheck the newly-added files for unused param names like
this one.

> Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp:43
> +    return nullptr; //
static_cast<PageClientImpl&>(pageClient()).viewBackend();

The commented-out code in this file seems like it should be removed.