[webkit-reviews] review granted: [Bug 203300] Web Inspector: add ITML debuggable/target type : [Attachment 387896] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 203300: Web Inspector: add ITML debuggable/target type
https://bugs.webkit.org/show_bug.cgi?id=203300

Attachment 387896: Patch

https://bugs.webkit.org/attachment.cgi?id=387896&action=review




--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 387896
  --> https://bugs.webkit.org/attachment.cgi?id=387896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387896&action=review

r=me!

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:203
> +	   for (let [targetType, command] of
domain._supportedCommandsForTargetType) {
> +	       if (!supportedTargetTypes.has(targetType))
> +		   continue;

I think we should be able to write a test for this (namely the last line in an
LayoutTests/inspector test):

    InspectorTest.expectTrue(InspectorBackend.hasDomain("DOM"), "Web Debuggable
has DOM Domain");
    InspectorTest.expectTrue(InspectorBackend.hasCommand("DOM.requestNode"),
"DOM.requestNode is available");
   
InspectorTest.expectFalse(InspectorBackend.hasCommand("DOM.getDataBindingsForNo
de"), "DOM.getDataBindingsForNode is not available");