[webkit-reviews] review granted: [Bug 205443] [iOS] Issue mach sandbox extension to the frontboard and icon service when the attachment element is enabled : [Attachment 387940] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 205443: [iOS] Issue mach sandbox extension to the frontboard and icon
service when the attachment element is enabled
https://bugs.webkit.org/show_bug.cgi?id=205443

Attachment 387940: Patch

https://bugs.webkit.org/attachment.cgi?id=387940&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 387940
  --> https://bugs.webkit.org/attachment.cgi?id=387940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387940&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.cpp:7614
> +	  
SandboxExtension::createHandleForMachLookup("com.apple.iconservices",
WTF::nullopt, handle);

Should we handle icon services under a different radar? We probably need this
on macOS, too, so it would be nice to do both together?