[webkit-reviews] review granted: [Bug 205443] [iOS] Issue mach sandbox extension to the frontboard and icon service when the attachment element is enabled : [Attachment 386099] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 205443: [iOS] Issue mach sandbox extension to the frontboard and icon
service when the attachment element is enabled
https://bugs.webkit.org/show_bug.cgi?id=205443

Attachment 386099: Patch

https://bugs.webkit.org/attachment.cgi?id=386099&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 386099
  --> https://bugs.webkit.org/attachment.cgi?id=386099
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386099&action=review

r=me

> Source/WebKit/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=205443

Please add the radar

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:345
> +	  
SandboxExtension::createHandleForMachLookup("com.apple.frontboard.systemappserv
ices", WTF::nullopt, handle);

Do we have a similar situation on macOS (using a different mach-port)? We
should file a radar to investigate and address that, too.