[webkit-reviews] review granted: [Bug 206286] Add support for MediaStream video track rendering in GPUProcess : [Attachment 387910] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 206286: Add support for MediaStream video track rendering in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=206286

Attachment 387910: Patch

https://bugs.webkit.org/attachment.cgi?id=387910&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 387910
  --> https://bugs.webkit.org/attachment.cgi?id=387910
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387910&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLaye
r.mm:283
> +    CFArrayRef attachmentsArray =
CMSampleBufferGetSampleAttachmentsArray(sample.platformSample().sample.cmSample
Buffer, true);
> +    for (CFIndex i = 0; i < CFArrayGetCount(attachmentsArray); ++i) {
> +	   CFMutableDictionaryRef attachments =
checked_cf_cast<CFMutableDictionaryRef>(CFArrayGetValueAtIndex(attachmentsArray
, i));
> +	   CFDictionarySetValue(attachments,
kCMSampleAttachmentKey_DisplayImmediately, kCFBooleanTrue);
> +    }

You mentioned this hack in the ChangeLog, but it should have a FIXME here
because we're going to need a remote display layer for MSE and it will need to
honor timestamps.