[webkit-reviews] review granted: [Bug 206325] Add finite timeout when synchronously terminating a service worker : [Attachment 387875] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 16 02:39:16 PST 2020
youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 206325: Add finite timeout when synchronously terminating a service worker
https://bugs.webkit.org/show_bug.cgi?id=206325
Attachment 387875: Patch
https://bugs.webkit.org/attachment.cgi?id=387875&action=review
--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 387875
--> https://bugs.webkit.org/attachment.cgi?id=387875
Patch
LGTM.
In the future, we should be able to remove this syncTerminateWorker and use a
timer to kick in process termination if it does not answer soon enough.
View in context: https://bugs.webkit.org/attachment.cgi?id=387875&action=review
> Source/WebKit/ChangeLog:11
> + and tell the UI process to terminate the hanging service worker
process. Continue handling messages during
s/. C/. C/
> Source/WebKit/UIProcess/WebProcessPool.cpp:1771
> +void WebProcessPool::terminateServiceWorkers(const
WebCore::RegistrableDomain& domain, const PAL::SessionID& sessionID)
s/terminateServiceWorkers/terminateServiceWorkerProcess?
> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:429
> + for (auto processPool : WebProcessPool::allProcessPools())
auto*
> Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:39
> +#include <WebCore/ServiceWorkerIdentifier.h>
Does not seem necessary
More information about the webkit-reviews
mailing list