[webkit-reviews] review granted: [Bug 206321] Pass JSToken by const reference : [Attachment 387859] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 16 00:20:03 PST 2020
Saam Barati <sbarati at apple.com> has granted review:
Bug 206321: Pass JSToken by const reference
https://bugs.webkit.org/show_bug.cgi?id=206321
Attachment 387859: Patch
https://bugs.webkit.org/attachment.cgi?id=387859&action=review
--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 387859
--> https://bugs.webkit.org/attachment.cgi?id=387859
Patch
Actually it looks like this function doesn’t lex, so we’re ok. Passing it by
reference is ok since m_token won’t be updated
Can you verify also that it doesn’t end up lexing?
r=me
More information about the webkit-reviews
mailing list