[webkit-reviews] review granted: [Bug 206332] Use dataLogIf more regularly : [Attachment 387883] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 206332: Use dataLogIf more regularly
https://bugs.webkit.org/show_bug.cgi?id=206332

Attachment 387883: Patch

https://bugs.webkit.org/attachment.cgi?id=387883&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 387883
  --> https://bugs.webkit.org/attachment.cgi?id=387883
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387883&action=review

r=me with nits.

> Source/JavaScriptCore/ftl/FTLOSREntry.cpp:64
> +	   dataLogLnIf(Options::verboseOSR(),"	  OSR failed because we don't
have an entrypoint for ", bytecodeIndex, "; ours is for ",
entryCode->bytecodeIndex());

Can you add a space here?

> Source/JavaScriptCore/ftl/FTLOSREntry.cpp:71
> +    dataLogLnIf(Options::verboseOSR(),"    Values at entry: ", values);

ditto.

> Source/JavaScriptCore/ftl/FTLOSREntry.cpp:100
> +	   dataLogLnIf(Options::verboseOSR(),"	  OSR failed because stack
growth failed.");

ditto.

> Source/JavaScriptCore/ftl/FTLOSREntry.cpp:107
> +    dataLogLnIf(Options::verboseOSR(),"    Entry will succeed, going to
address ", RawPointer(result));

Ditto.

> Source/WTF/ChangeLog:9
> +	   (WTF::dataLog): Marked NEVER_INLINE

Why never inline this?