[webkit-reviews] review granted: [Bug 206329] Try to simplify the template deduction used by callOperation in DFGSpeculativeJIT : [Attachment 387879] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 15 17:51:19 PST 2020


Keith Miller <keith_miller at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 206329: Try to simplify the template deduction used by callOperation in
DFGSpeculativeJIT
https://bugs.webkit.org/show_bug.cgi?id=206329

Attachment 387879: Patch

https://bugs.webkit.org/attachment.cgi?id=387879&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 387879
  --> https://bugs.webkit.org/attachment.cgi?id=387879
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387879&action=review

r=me with question.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:-954
> -    callOperation(OperationType operation, NoResultTag, Args... args)

Does anyone use NoResultTag now? If not, we should just get rid of it.


More information about the webkit-reviews mailing list