[webkit-reviews] review denied: [Bug 206321] Pass JSToken by const reference : [Attachment 387859] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 15 17:11:18 PST 2020


Saam Barati <sbarati at apple.com> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 206321: Pass JSToken by const reference
https://bugs.webkit.org/show_bug.cgi?id=206321

Attachment 387859: Patch

https://bugs.webkit.org/attachment.cgi?id=387859&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 387859
  --> https://bugs.webkit.org/attachment.cgi?id=387859
Patch

This call site concerns me since m_token is a field that's updated as we parse
more things

    pattern = createBindingPattern(context, kind, exportType,
*m_token.m_data.ident, m_token, bindingContext, duplicateIdentifier);


More information about the webkit-reviews mailing list