[webkit-reviews] review granted: [Bug 206313] fast/forms/ios/zoom-after-input-tap-wide-input.html is timing out : [Attachment 387839] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 206313: fast/forms/ios/zoom-after-input-tap-wide-input.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=206313

Attachment 387839: Patch

https://bugs.webkit.org/attachment.cgi?id=387839&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 387839
  --> https://bugs.webkit.org/attachment.cgi?id=387839
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387839&action=review

> Tools/WebKitTestRunner/TestController.cpp:1090
> +	   return false;

It's not obvious to me what effects bailing early here in
TestController::resetPreferencesToConsistentValues would have on the subsequent
test, since we're only half done resetting test harness state (among other
things, we'd skip waiting for about:blank to load).

Perhaps we should consider either raising an exception (and crashing) or simply
continuing with the rest of the function here.