[webkit-reviews] review granted: [Bug 206261] Keep RefPtr instead of raw pointer to message queue on WebCoreResourceHandleAsOperationQueueDelegate : [Attachment 387749] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 206261: Keep RefPtr instead of raw pointer to message queue on
WebCoreResourceHandleAsOperationQueueDelegate
https://bugs.webkit.org/show_bug.cgi?id=206261

Attachment 387749: Patch

https://bugs.webkit.org/attachment.cgi?id=387749&action=review




--- Comment #9 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 387749
  --> https://bugs.webkit.org/attachment.cgi?id=387749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387749&action=review

r=me if code in CurlRequest.h is okay.

> Source/WebCore/platform/network/curl/CurlRequest.h:67
> +    static Ref<CurlRequest> create(const ResourceRequest& request,
CurlRequestClient& client, ShouldSuspend shouldSuspend = ShouldSuspend::No,
EnableMultipart enableMultipart = EnableMultipart::No,
CaptureNetworkLoadMetrics captureMetrics = CaptureNetworkLoadMetrics::Basic,
RefPtr<SynchronousLoaderMessageQueue>&& messageQueue = nullptr)

Is assigning `nullptr` to the default value of a RefPtr<...>&& type allowed?