[webkit-reviews] review granted: [Bug 204588] [css-grid] Exclude implicit tracks from grid-template-rows/columns resolved values : [Attachment 387660] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 204588: [css-grid] Exclude implicit tracks from grid-template-rows/columns
resolved values
https://bugs.webkit.org/show_bug.cgi?id=204588

Attachment 387660: Patch

https://bugs.webkit.org/attachment.cgi?id=387660&action=review




--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 387660
  --> https://bugs.webkit.org/attachment.cgi?id=387660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387660&action=review

r=me. Thanks for taking care of this.

> Source/WebCore/rendering/RenderGrid.cpp:872
> +    // Usually we have `explicitEnd <= numPositions - 1`, but the latter may
be
> +    // smaller when the maximum number of tracks is reached.

Super nit: Not need to wrap this comment line, it's not that long for WebKit
standards.