[webkit-reviews] review granted: [Bug 206268] REGRESSION (r253394): After swiping back during a navigation, WKWebView gets stuck with the forward content, stops repainting : [Attachment 387736] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 206268: REGRESSION (r253394): After swiping back during a navigation,
WKWebView gets stuck with the forward content, stops repainting
https://bugs.webkit.org/show_bug.cgi?id=206268

Attachment 387736: Patch

https://bugs.webkit.org/attachment.cgi?id=387736&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 387736
  --> https://bugs.webkit.org/attachment.cgi?id=387736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387736&action=review

> Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:262
>      m_didCallWillEndSwipeGesture = false;
> +    m_didCallEndSwipeGesture = false;
> +    m_removeSnapshotImmediatelyWhenGestureEnds = false;

Starting to feel like a state machine.