[webkit-reviews] review canceled: [Bug 205368] [Cocoa] Create a simulated crash log when the UI Process receives an invalid IPC message : [Attachment 387594] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 14 16:25:04 PST 2020
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 205368: [Cocoa] Create a simulated crash log when the UI Process receives
an invalid IPC message
https://bugs.webkit.org/show_bug.cgi?id=205368
Attachment 387594: Patch v2
https://bugs.webkit.org/attachment.cgi?id=387594&action=review
--- Comment #16 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 387594
--> https://bugs.webkit.org/attachment.cgi?id=387594
Patch v2
View in context: https://bugs.webkit.org/attachment.cgi?id=387594&action=review
>> Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:276
>> + RELEASE_LOG_FAULT(IPC, "Received an invalid message '%s::%s' from the
%s process.", messageReceiverName.toString().data(),
messageName.toString().data(), processName().utf8().data());
>
> Don't we need %{public}s ?
Fixed.
>> Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:123
>> + virtual String processName() const = 0;
>
> Seems like this could return an ACSIILiteral
Fixed.
More information about the webkit-reviews
mailing list