[webkit-reviews] review granted: [Bug 205790] [iOS] Enable SPI to toggle PIP and to query PIP state and availability : [Attachment 387697] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Luming Yin <luming_yin at apple.com>'s
request for review:
Bug 205790: [iOS] Enable SPI to toggle PIP and to query PIP state and
availability
https://bugs.webkit.org/show_bug.cgi?id=205790

Attachment 387697: Patch

https://bugs.webkit.org/attachment.cgi?id=387697&action=review




--- Comment #9 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 387697
  --> https://bugs.webkit.org/attachment.cgi?id=387697
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387697&action=review

r=me with nits

> Source/WebKit/UIProcess/WebPageProxy.cpp:5991
> +    PlatformPlaybackSessionInterface* playbackSessionInterface =
sessionManager->controlsManagerInterface();
> +    if (!playbackSessionInterface)
> +	   return nullptr;

if (auto playbackSessionInterface = sessionManager->controlsManagerInterface())
  return playbackSessionInterface->playbackSessionModel();
return nullptr;

> Source/WebKit/UIProcess/WebPageProxy.cpp:5999
> +    WebCore::PlaybackSessionModel* sessionModel = playbackSessionModel();
> +    if (sessionModel)

if (auto sessionModel = playbackSessionModel())

> Source/WebKit/UIProcess/WebPageProxy.cpp:6006
> +    WebCore::PlaybackSessionModel* sessionModel = playbackSessionModel();
> +    if (sessionModel)

Ditto.

> Source/WebKit/UIProcess/WebPageProxy.cpp:6015
> +    PlaybackSessionModel* sessionModel = playbackSessionModel();
> +    if (sessionModel)

Ditto.