[webkit-reviews] review granted: [Bug 206084] Add modulemap for WebKit Private APIs (take 2) : [Attachment 387439] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 206084: Add modulemap for WebKit Private APIs (take 2)
https://bugs.webkit.org/show_bug.cgi?id=206084

Attachment 387439: Patch

https://bugs.webkit.org/attachment.cgi?id=387439&action=review




--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 387439
  --> https://bugs.webkit.org/attachment.cgi?id=387439
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387439&action=review

> Source/WebKit/Shared/API/Cocoa/WebKitPrivate.h:31
> +#import <WebKit/DOMHTMLMediaElement.h>

I wooooonder if we should not include the WebKitLegacy headers, and tuck them
in a TAPI -extra-private-header (aka the way to lie to TAPI). Probably the
correct answer is "no" but it feels so much less dirty :(