[webkit-reviews] review granted: [Bug 205706] Enable the offset assertion in HTMLTextFormControlElement::indexForPosition : [Attachment 387625] Updated

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 205706: Enable the offset assertion in
HTMLTextFormControlElement::indexForPosition
https://bugs.webkit.org/show_bug.cgi?id=205706

Attachment 387625: Updated

https://bugs.webkit.org/attachment.cgi?id=387625&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 387625
  --> https://bugs.webkit.org/attachment.cgi?id=387625
Updated

View in context: https://bugs.webkit.org/attachment.cgi?id=387625&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2035
> +    return WebCore::indexForVisiblePosition(*node, position, {
TextIteratorLegnthOption::GenerateSpacesForReplacedElements });

Typo here: "legnth".

> Source/WebCore/editing/TextIteratorBehavior.h:64
>  typedef unsigned short TextIteratorBehavior;

Should move this one to OptionSet too later, right?