[webkit-reviews] review granted: [Bug 198918] Use even more "shortest form" formatting, and less "fixed precision" and "fixed width" : [Attachment 387538] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 198918: Use even more "shortest form" formatting, and less "fixed
precision" and "fixed width"
https://bugs.webkit.org/show_bug.cgi?id=198918

Attachment 387538: Patch

https://bugs.webkit.org/attachment.cgi?id=387538&action=review




--- Comment #32 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 387538
  --> https://bugs.webkit.org/attachment.cgi?id=387538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387538&action=review

Very nice!

> Source/JavaScriptCore/API/tests/ExecutionTimeLimitTest.cpp:201
> +	       CString scriptText = makeString(

I wonder if would make sense to have a makeUTF8CString function like this?
Obviously, if tests were the only users, probably not, but I will keep an eye
out for other cases.