[webkit-reviews] review granted: [Bug 206234] [GStreamer] Several buffering fixes : [Attachment 387656] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 206234: [GStreamer] Several buffering fixes
https://bugs.webkit.org/show_bug.cgi?id=206234

Attachment 387656: Patch

https://bugs.webkit.org/attachment.cgi?id=387656&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 387656
  --> https://bugs.webkit.org/attachment.cgi?id=387656
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387656&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2308
> +    GST_TRACE_OBJECT(pipeline(), "did download finish %s",
boolForPrinting(m_didDownloadFinish));

did download finish?

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2593
> +		       gst_query_parse_buffering_percent(query.get(),
(gboolean*) &m_isBuffering, NULL);

Casting a bool to gboolean is a bad idea, please proxy it thru a gboolean
isBuffering.

NULL -> nullptr