[webkit-reviews] review granted: [Bug 201641] Map HTML attributes width/height to the default aspect ratio of <img> : [Attachment 387636] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) - OOO until January 6 <fred.wang at free.fr> has granted
cathiechen <cathiechen at igalia.com>'s request for review:
Bug 201641: Map HTML attributes width/height to the default aspect ratio of
<img>
https://bugs.webkit.org/show_bug.cgi?id=201641

Attachment 387636: Patch

https://bugs.webkit.org/attachment.cgi?id=387636&action=review




--- Comment #42 from Frédéric Wang (:fredw) - OOO until January 6
<fred.wang at free.fr> ---
Comment on attachment 387636
  --> https://bugs.webkit.org/attachment.cgi?id=387636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387636&action=review

This LGTM, but I don't see the same bug for div in
https://bugs.webkit.org/show_bug.cgi?id=206161

> Source/WebCore/ChangeLog:10
> +	   img element's layout size before loading. The value will be
overridden if img is loaded. Also see [2].

Maybe explain the plan for future elements? I think Blink does some
non-yet-standard things for video?

> Source/WebKit/Shared/WebPreferences.yaml:1518
> +  humanReadableDescription: "Map HTML attributes width/height to the default
aspect ratio of <img>"

Maybe this should be renamed AspectRatioOfImgFromWidthAndHeightEnabled in case
we decide to support the same for other elements in the future?

> LayoutTests/imported/w3c/ChangeLog:10
> +	   *
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-con
tent-and-images/img-aspect-ratio-expected.txt:

Can you please mention that one case still fails because of
https://bugs.webkit.org/show_bug.cgi?id=206161 ?