[webkit-reviews] review denied: [Bug 77568] [Cocoa] Glyph lookup should be language-sensitive (specifically between Yiddish and Hebrew) : [Attachment 387606] Doesn't affect font hash

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 77568: [Cocoa] Glyph lookup should be language-sensitive (specifically
between Yiddish and Hebrew)
https://bugs.webkit.org/show_bug.cgi?id=77568

Attachment 387606: Doesn't affect font hash

https://bugs.webkit.org/attachment.cgi?id=387606&action=review




--- Comment #70 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 387606
  --> https://bugs.webkit.org/attachment.cgi?id=387606
Doesn't affect font hash

View in context: https://bugs.webkit.org/attachment.cgi?id=387606&action=review

> Source/WebCore/platform/graphics/Font.h:286
> +    struct CFStringAttributesKey {

This struct name makes it sound like attributes of a CFString.

> Source/WebCore/platform/graphics/Font.h:322
> +	   bool enableKerning;
> +	   FontOrientation orientation;
> +	   AtomString locale;

It bugs me seeing small members before big members (packing).

> Source/WebCore/platform/graphics/GlyphBuffer.h:167
> +	   auto originalSize = size();

Maybe assert that location < size().

> Source/WebCore/platform/graphics/GlyphBuffer.h:170
> +	   m_fonts.grow(length);

This is wrong. grow() takes the new size, so you want size() + length.