[webkit-reviews] review granted: [Bug 206144] [JSC] Use internal object field mechanism to implement JSStringIterator : [Attachment 387491] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 206144: [JSC] Use internal object field mechanism to implement
JSStringIterator
https://bugs.webkit.org/show_bug.cgi?id=206144

Attachment 387491: Patch

https://bugs.webkit.org/attachment.cgi?id=387491&action=review




--- Comment #6 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 387491
  --> https://bugs.webkit.org/attachment.cgi?id=387491
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387491&action=review

r=me, looks straightforward.

> Source/JavaScriptCore/builtins/BuiltinNames.h:-53
> -    macro(arrayIteratorNextIndex) \
> -    macro(arrayIterationKind) \
> -    macro(arrayIteratorNext) \
> -    macro(arrayIteratorIsDone) \
> -    macro(arrayIteratorKind) \

These are leftover from r254252, I take it?

> JSTests/stress/tailCallForwardArguments.js:6
> -var putFuncToPrivateName = createBuiltin(`(function (func) {
@arrayIteratorIsDone = func })`)
> +var putFuncToPrivateName = createBuiltin(`(function (func) { @generatorThis
= func })`)

Ahh, so this test had just arbitrarily chosen to write to a private name you're
removing?